search

pyrooka / metabase-cubejs-driver

Connect Metabase with Cube.js.
GNU Affero General Public License v3.0
4 stars 6 forks source link

Fix Broken beforeDate and afterDate time filters #52

Closed igorpojzl closed 4 years ago

igorpojzl commented 4 years ago

Issue Reference this PR resolves

Broken beforeDate and afterDate time filters #48

igorpojzl commented 4 years ago

@pyrooka Please review.

pyrooka commented 4 years ago

Thanks for the fix! One little thing: please try to avoid copying large code blocks if it is not necessary because it makes the review harder.

pyrooka commented 4 years ago

Have you tested the other filters? For me, the others look like broken: image

pyrooka commented 4 years ago

MBQL: :filter [:and [:= [:field-id 40] [:value Harry {:base_type :type/Text, :special_type :type/Category, :database_type string}]] [:< [:datetime-field [:field-id 43] :default] [:absolute-datetime (t/zoned-date-time 1990-03-31T00:00Z[GMT]) :default]]] Native: :filters [{:member Characters.birth, :operator beforeDate, :values [1990-03-31T00:00:00Z]}]