search

pyrooka / metabase-cubejs-driver

Connect Metabase with Cube.js.
GNU Affero General Public License v3.0
4 stars 6 forks source link

CubeCloud Request Span Annotation #53

Closed norbertbede closed 4 years ago

norbertbede commented 4 years ago

Is your feature request related to a problem? Please describe. We start evaluate thanks to early access CUBE CLOUD, for compactibility rest api require some changes. https://cube.dev/docs/rest-api#prerequisites-request-span-annotation

Describe the solution you'd like implement span annotation https://cube.dev/docs/rest-api#prerequisites-request-span-annotation

pyrooka commented 4 years ago

Good idea! I don't know how the spanId and the requestSequenceId should be chosen. Could you provide some information about this?

igorpojzl commented 4 years ago

I think spanId is unique for each query in make-request (UUID generator?). requestSequenceId should be sequence with first value 1000000, and incrementing with each retry of same query.

pyrooka commented 4 years ago

Yes, you are right! Thanks again for this!

norbertbede commented 4 years ago

tested on our dev build. result: works - we are going today analyse more how it works and how we can improve it if required.

pyrooka commented 4 years ago

Sounds good! We don't have Cube Cloud access so cannot test it and to be honest I don't really know what Cube Cloud is.