search

pyrooka / metabase-cubejs-driver

Connect Metabase with Cube.js.
GNU Affero General Public License v3.0
4 stars 6 forks source link

Feature view sql support #65

Closed igorpojzl closed 4 years ago

igorpojzl commented 4 years ago

Description of Changes Made (if issue reference is not provided)

Moved JSON stringify from function execute-http-request to function driver/mbql->native so Metabase will support View the Sql when asking questions instead of empty.

Screenshot 2020-04-15 at 13 48 38

Also removed IF condition which checked if old mbql query is not empty and returning empty rows. This need to be tested if there is not any hidden bugs after removing this check.

igorpojzl commented 4 years ago

@pyrooka May i ask why we were stringify native query in Execute Query? And what purpose had that IF Condition?

pyrooka commented 4 years ago

I guess that is just a leftover from the early stages. If the driver works well without that it can be removed.