search

pyrooka / metabase-cubejs-driver

Connect Metabase with Cube.js.
GNU Affero General Public License v3.0
4 stars 6 forks source link

Fix dateformat timedimension #69

Open igorpojzl opened 4 years ago

igorpojzl commented 4 years ago

Check List

Issue Reference this PR resolves

Metabase generates wrong dateformat for timedimension #68

pyrooka commented 4 years ago

Some queries still generate the wrong filter. Please check these cases:

Filter: on E.g.: Character S. Birth is April 22, 2020 Query:

{
  "dimension": "Characters.birth",
  "dateRange": [
    "2020-04-22T00:00:00Z",
    "2020-04-23T00:00:00Z"
  ]
}

Filter: between E.g.: Character S. Birth between April 1, 2020 April 3, 2020 Query:

{
  "dimension": "Characters.birth",
  "dateRange": [
    "2020-04-01T00:00:00Z",
    "2020-04-04T00:00:00Z"
  ]
}
igorpojzl commented 4 years ago

I will check it out.