pyropy / fastapi-socketio

Easily integrate socket.io with your FastAPI app πŸš€
Apache License 2.0
328 stars 31 forks source link

PIP Installation Result in Empty/Incomplete Module #5

Closed tolmanam closed 3 years ago

tolmanam commented 3 years ago

The PIP command appears to work:

$ pip install fastapi-socketio
Collecting fastapi-socketio
  Downloading fastapi_socketio-0.1-py3-none-any.whl (6.0 kB)
Installing collected packages: fastapi-socketio
Successfully installed fastapi-socketio-0.1

But the resulting module is effectively empty:

$ find .../site-packages/fastapi_socketio/
.../site-packages/fastapi_socketio/
.../site-packages/fastapi_socketio/__pycache__
.../site-packages/fastapi_socketio/__pycache__/__init__.cpython-38.pyc
.../site-packages/fastapi_socketio/__init__.py

The __init__py looks like a stub.

$ cat .../site-packages/fastapi_socketio/__init__.py 
def example_function():
    return 1 + 1
pyropy commented 3 years ago

Thank you for reporting the issue, will resolve it soonπŸ˜πŸ€

pyropy commented 3 years ago

@tolmanam Thanks for reporting the issue, I resolved it. Turns out I should actually change package version in setup.py also :smile:

I suck at this stuff :smile:

Thank you once again for reporting :rocket:

tolmanam commented 3 years ago

Great! Thank you for putting this together and for the quick fix.

pyropy commented 3 years ago

@tolmanam No problems, If you have any suggestions for features or feedback feel free to make another issue!