pyros-dev / catkin_pip

Catkin extension to play nice with usual python packages and workflow
10 stars 8 forks source link

catkin_pip_requirements improvements #142

Open asmodehn opened 7 years ago

asmodehn commented 7 years ago

Currently catkin_pip requirements does a pip install -r requirements.txt like so : https://github.com/pyros-dev/catkin_pip/blob/devel/cmake/catkin-pip-requirements.cmake.in#L32

However this can be a bad match for CMake since, pip install actually takes care of the equivalent of :

This can lead to confusions, like "why do we need to modify the source tree? Everything should be in the build tree to be able to clean up."

Maybe this feature will be better integrated with another ROS tool ?

asmodehn commented 7 years ago

Note we need to be extra careful with this, since any downloaded source needs to be importable from the original project.

Having it in src is an easy way to ensure that. Putting it somewhere else, we need to be careful to :