search

pyros-dev / pyros-msgs

ROS messages and service definitions for use with pyros
MIT License
0 stars 3 forks source link

get rid of duplicated tests setup #26

Open asmodehn opened 7 years ago

asmodehn commented 7 years ago

We have two main sets of requirements :

Since we extracted the tests from the main package for simplicity (especially for managing backward compatiblity and pure python testing), there is probably no need to have the tests dependencies version based on rosdistro. We should be fine using latest test dependencies. This reduces the number of dependencies for the package, and forces us to do development work in a recent python environment (as per usual python workflow).

We will lose the possibility of running tests in old environments (unless we do https://github.com/pyros-dev/catkin_pip/issues/104), and we would build ros package without tests... It might not be ideal, but saves quite some time and reduces complexity, especially because we can manage testing in multiple versions easily with tox and a set of requirements...

It means, we are relying on the linux distro to provide a consistent, up-to-date, python environment. That might be "good enough", and make our lives much simpler. ROS packages then become a backport of python packages, which is the intent anyway.

So, with that in mind, it seems we can get rid of our deb envs requirement set...

asmodehn commented 7 years ago

This should be done in https://github.com/pyros-dev/pyros-msgs/pull/14

asmodehn commented 6 years ago

PR has been merged, but this still remains... It shall be done in parallel with ROS Third party release repo.