search

pyros-dev / pyros

Python interfacing for multiprocess software - A Python blanket for ROS to hide inside
BSD 3-Clause "New" or "Revised" License
24 stars 4 forks source link

Do not use rospy MasterAPI as a reference #109

Open asmodehn opened 7 years ago

asmodehn commented 7 years ago

Currently in the code the rospy master getSsytemState() datastructure is used as a reference.

However this list of list of list is quite inefficient, and unnecessarily complex to manipulate... We should establish and use a different data format, likely based on dictionaries (for optimized access) and sets (for optimisedset operations)

stonier commented 7 years ago

You are a bit slow on this decision ;). This ideally should be a useful functionality provided by the connection cache.

On 4 Nov 2016 10:03, "AlexV" notifications@github.com wrote:

Currently in the code the rospy master getSsytemState() datastructure is used as a reference.

However this list of list of list is quite inefficient, and unnecessarily complex to manipulate... We should establish and use a different data format, likely based on dictionaries (for optimized access) and sets (for optimisedset operations)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/asmodehn/pyros/issues/109, or mute the thread https://github.com/notifications/unsubscribe-auth/AAp9EijGD98Bji40XbJcdHvvG8cmcWqhks5q6oR5gaJpZM4KpFcm .

asmodehn commented 7 years ago

The connection cache (and proxy) already provide data in a different format. It's the function calls inside pyros that do some unneeded gymnastic between the two data formats...