search

pyros-dev / pyros

Python interfacing for multiprocess software - A Python blanket for ROS to hide inside
BSD 3-Clause "New" or "Revised" License
25 stars 4 forks source link

Clean up ros interface #20

Closed heuristicus closed 8 years ago

heuristicus commented 9 years ago

Currently add_topic and expose_topic have very similar functionality, and having both makes things very confusing.

asmodehn commented 9 years ago

Hmmm we probably should refactor this part of the code... but before doing that we should have all unit tests in place ( regarding parameters passing /vs/ available topics/services ) to make sure we don't break anything in the process. On Jul 31, 2015 6:00 PM, "Michal Staniaszek" notifications@github.com wrote:

Currently add_topic and expose_topic have very similar functionality, and having both makes things very confusing.

The topics_args are used in a couple of places, but they don't seem to follow what is their expected use - if anything is added to those lists, it is not displayed in the REST interface.

— Reply to this email directly or view it on GitHub https://github.com/asmodehn/rostful-node/issues/20.

asmodehn commented 8 years ago

The interface has been changed as part of the refactoring to 0.1