search

pyroscope / rtorrent-ps

:art: Extended rTorrent distribution with a fully customizable canvas and colors, other feature additions, and complete docs.
http://rtorrent-ps.readthedocs.io/
GNU General Public License v2.0
463 stars 43 forks source link

Typo in xmlrpc-c-advanced-2954/common.mk #119

Open zetafunction opened 5 years ago

zetafunction commented 5 years ago

It looks like this is pulled via a source tarball, so I'm not sure how to send a pull request. common.mk defines LDFLAGS_FOR_BUILD_ALL, but gennmtab's Makefile expects it to be named LDFLAGS_ALL_FOR_BUILD. This typo prevents linker flags added in LADD from being used when building gennmtab.

Simple patch:

--- common.mk.orig      2019-01-13 09:46:36.483669731 -0800
+++ common.mk   2019-01-13 09:46:46.355988659 -0800
@@ -96,7 +96,7 @@

 LDFLAGS_ALL = $(LDFLAGS_PTHREAD) $(LDFLAGS_PERSONAL) $(LDFLAGS)

-LDFLAGS_FOR_BUILD_ALL = \
+LDFLAGS_ALL_FOR_BUILD = \
   $(LDFLAGS_PTHREAD) $(LDFLAGS_PERSONAL) $(LDFLAGS_FOR_BUILD)

 ##############################################################################