search

pyrra-dev / pyrra

Making SLOs with Prometheus manageable, accessible, and easy to use for everyone!
https://demo.pyrra.dev
Apache License 2.0
1.25k stars 113 forks source link

webhook: fix panic on unedpected parser expression #1182

Closed squat closed 6 months ago

squat commented 6 months ago

Even if a vector expression in an SLO returns a vector, the webhook API handler will panic if the underlying expression is not a vector selctor.

Fixes: https://github.com/pyrra-dev/pyrra/issues/1181

Signed-off-by: squat lserven@gmail.com

metalmatze commented 6 months ago

Good find and thanks for the fix! Do you want to send a similar one against the release-0.7 branch? We could then cut a new patch release.

squat commented 6 months ago

Oh yeah happily!

squat commented 6 months ago

Grrrr I think the release-0.7 branch was deleted! https://github.com/pyrra-dev/pyrra/tree/release-0.7

metalmatze commented 6 months ago

I fat-fingered and deleted that branch after #1145 it seems like. It's back now to send PRs against. Sorry about that.