search

pyrra-dev / pyrra

Making SLOs with Prometheus manageable, accessible, and easy to use for everyone!
https://demo.pyrra.dev
Apache License 2.0
1.26k stars 113 forks source link

Absent Alert not disabled when using `spec.alerting.disabled=true` #1226

Open svenmueller opened 4 months ago

svenmueller commented 4 months ago

Setting spec.alerting.disabled=true doesn't disable both alerts (absent, burnrates) as mentioned here

Disabled is used to disable the generation of alerts. Recording rules are still generated.

Absent alerts can only be disabled setting spec.alerting.absent=false https://github.com/pyrra-dev/pyrra/blob/a5e3b4606daf843156111f791ff669d864163e7a/slo/rules.go#L704