The GenericRules is using sum() in counter metrics

pyrra-dev / pyrra

Making SLOs with Prometheus manageable, accessible, and easy to use for everyone!

https://demo.pyrra.dev

Apache License 2.0

1.21k stars 108 forks source link

Open jenciso opened 1 month ago

jenciso commented 1 month ago

The Generic rules:

pyrra_requests_total (See here and here also)
pyrra_errors_total (See here) Are using sum() Prometheus functions without use before rate(). It generates peaks and obviously, it doesn't make sense sum counters if you don't use rate before, it is explained here

It seems a bug. Please let me know if I am wrong. Thank you

jenciso commented 1 month ago

@metalmatze Sorry for interrupting you, I would like you to have the chance to see this question. I appreciate any help you can provide.

metalmatze commented 1 month ago

Hey, unfortunately, you're right. There's already an issue here. Right now I have little time to fix the problem: https://github.com/pyrra-dev/pyrra/issues/968

metalmatze commented 1 month ago

If you know how to fix it, a PR would be greatly appreciated! I'm busy organizing PromCon until mid-September...