search

pyrus / Pyrus_Developer

Developer tools for building PEAR compatible packages
7 stars 7 forks source link

Removed the "vendor" folder and added it to .gitignore #29

Open boenrobot opened 10 years ago

boenrobot commented 10 years ago

What's with this practice of having a "vendor" dir containing a whole PEAR2 installation with dependencies anyway? Those should not be in a VCS, even if they're important for development (which those frankly aren't), but should be installed separately.

cellog commented 10 years ago

They are (were) used when generating the Pyrus.phar On Jul 31, 2014 4:20 PM, "Vasil Rangelov" notifications@github.com wrote:

What's with this practice of having a "vendor" dir containing a whole PEAR2 installation with dependencies anyway? Those should not be in a VCS, even if they're important for development (which those frankly aren't), but

should be installed separately.

You can merge this Pull Request by running

git pull https://github.com/boenrobot/Pyrus_Developer vendor-clean

Or view, comment on, or merge it at:

https://github.com/pyrus/Pyrus_Developer/pull/29 Commit Summary

  • Removed the "vendor" folder and added it to .gitignore;

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/pyrus/Pyrus_Developer/pull/29.

boenrobot commented 10 years ago

For Pyrus itself... sure... I can understand that to generate an installer you need to not be dependent on an installer.

But surely that's not required for a plugin such as Pyrus_Developer, or any other package, right?

cellog commented 10 years ago

I had not noticed this was Pyrus_Developer :) I agree with you On Aug 1, 2014 5:22 PM, "Vasil Rangelov" notifications@github.com wrote:

For Pyrus itself... sure... I can understand that to generate an installer you need to not be dependent on an installer.

But surely that's not required for a plugin such as Pyrus_Developer, or any other package, right?

— Reply to this email directly or view it on GitHub https://github.com/pyrus/Pyrus_Developer/pull/29#issuecomment-50936397.