search

pyrus / Pyrus_Developer

Developer tools for building PEAR compatible packages
7 stars 7 forks source link

pear2skeleton #5

Closed till closed 13 years ago

till commented 13 years ago

Took a couple hours to refactor this part.

I'd like to get some feedback if this is acceptable for everyone and then I would move and rip out the rest from the Commands class to make it more testable. ;-)

till commented 13 years ago

Just updated this request.

I'd pronounce this done. Happy to get some feedback.

saltybeagle commented 13 years ago

Things look good. One command down, 10 more to go?

saltybeagle commented 13 years ago

Oh, and you know I'm not a fan of PHPUnit, but coverage is coverage I guess.

Once this is done, do you think you can tackle the additions we had discussed? Simplification and adding the --extended --full-blown --everything-but-the-heart skeleton option?

till commented 13 years ago

Thanks for the merge!

  1. PHPUnit, yeah, I just needed something I'm very familiar with. I can work on converting those to PHPT later on too.
  2. Yeah, once I tackled Commands.php, I plan on extending skeleton creation. :-)