pyrus / Pyrus_Developer

Developer tools for building PEAR compatible packages
7 stars 7 forks source link

Ignore VCS files during `pyrus.phar make` #9

Closed saltybeagle closed 12 years ago

saltybeagle commented 12 years ago

Originally from pyrus/Pyrus#72, @fpoirotte —

When running pyrus.phar make ..., it will create/update a package.xml file by recursively scanning directories from a standard layout. While doing so, it picks up VCS related files (in my case, the ".git" directory from a git submodule).

I think such directories should be ignored by default (maybe with an option to override the patterns in case you want to include some of those files). For example, most tasks in Phing will ignore the following directories by default:

The same could also apply to files (to prevent files such as "foo.php.bak", "foo.php~", ".foobar.swp", etc. from being added to the package).

saltybeagle commented 12 years ago

The file list is generated from a simple directory iterator. There's already a filter iterator class, we could add whatever is needed there, or add other filters for the each VCS.

https://github.com/pyrus/Pyrus_Developer/blob/master/src/Pyrus/Developer/PackageFile/PEAR2SVN/Filter.php

Specifically, here we ignore .svn: https://github.com/pyrus/Pyrus_Developer/blob/master/src/Pyrus/Developer/PackageFile/PEAR2SVN/Filter.php#L28