search

pysal / access

Classical and novel measures of spatial accessibility to services
https://pysal.org/access/
BSD 3-Clause "New" or "Revised" License
22 stars 13 forks source link

Hard coded origin name #17

Closed tommlogan closed 2 years ago

tommlogan commented 2 years ago

Line 302 of fca.py W3sum_frame = cost_df[["origin", "W3"]].groupby('origin').sum().rename(columns = {"W3" : "W3sum"}).reset_index() I believe should be W3sum_frame = cost_df[[cost_origin, "W3"]].groupby(cost_origin).sum().rename(columns = {"W3" : "W3sum"}).reset_index()

The current one hard-codes the name of cost origin which is inconsistent with code and causes an issue when the demand and supply indices are not equal.

knaaptime commented 2 years ago

confirming this is still an issue

JamesSaxon commented 2 years ago

Fixed in code, will take a moment to get new release.