search

pysal / access

Classical and novel measures of spatial accessibility to services
https://pysal.org/access/
BSD 3-Clause "New" or "Revised" License
22 stars 13 forks source link

old versions of nose require older setuptools #20

Closed JamesSaxon closed 2 years ago

JamesSaxon commented 2 years ago

Trying to fix documentation auto build, which is now out of date:

https://readthedocs.org/projects/access/builds/15870255/

setuptools has moved on with its life, and dropped use2_3 in 58.0.0.

knaaptime commented 2 years ago

we could also modernize the doc-building process and bring it in line with the other pysal packages by merging #16 (docs would also get published to pysal.org/access, which would be nice). I'm happy to run with that

JamesSaxon commented 2 years ago

Hi Eli -- sorry, I misread your post long ago and classed as "way more work than I have time for right now." I hadn't seen that you did a lot of the work.

If you think this is "fairly straightforward," I'm tempted to go along, since trivial changes in the code often break the much-less trivial and constantly aging ecosystem of build scripts / dependencies. My big hesitation on this is that I think this entails a switch from rtd the gh-pages -- will this entail a rewrite of any of the Sphinx pages? They can be a pain (e.g., was really annoying to get the class functions to show up & link correctly).

knaaptime commented 2 years ago

agreed, rtd can be a real pain (part of the reason we moved to gh-pages). This should actually get us around a lot of those weird issues. As long as the docs build locally, they should build just fine in gha (unlike RTD...). I'll take another pass at this to make sure everything builds, but there shouldn't be any re-writing necessary. Moving forward, me and @jgaboardi are always happy to help keep things in order :)

knaaptime commented 2 years ago

docs are live at https://pysal.org/access/

knaaptime commented 2 years ago

i think this can be closed now that the docs are up on pysal.org, but we should also take down readthedocs so there arent two potentially conflicting versions available on the web