search

pysal / access

Classical and novel measures of spatial accessibility to services
https://pysal.org/access/
BSD 3-Clause "New" or "Revised" License
22 stars 13 forks source link

Change max cost to include threshold #27

Open JamesSaxon opened 2 years ago

JamesSaxon commented 2 years ago

This is a change was requested by @knaaptime in the discussion for 26. It is a one-character fix here:

https://github.com/pysal/access/blob/bfae8edbbcb304e67884a3b1cbf292cc410fa380/access/fca.py#L55

But it will also break the expectations of the zero-catchment tests here:

https://github.com/pysal/access/blob/bfae8edbbcb304e67884a3b1cbf292cc410fa380/access/tests/test_floating_catchment_area.py#L75-L80

Not a hard change but your judgment call.

JamesSaxon commented 2 years ago

Hey @knaaptime, just following up here. Happy to update the code and tests, but wanted one last confirmation on your side...

jGaboardi commented 2 years ago

@JamesSaxon Do we want to wait for Eli's response before doing this next release?

JamesSaxon commented 2 years ago

@jGaboardi, unless it's a ton of work for you, I'd rather just get that piece out.