pysal / access

Classical and novel measures of spatial accessibility to services
https://pysal.org/access/
BSD 3-Clause "New" or "Revised" License
21 stars 13 forks source link

Update versioneer, etc #39

Closed jGaboardi closed 2 years ago

jGaboardi commented 2 years ago

This PR updates the versioning implementation using versioner (xref #21), along with minor updates to doc links in README.md. Also, the .pre-commit-config.yml is added, which must be set up locally by devs individually.

codecov[bot] commented 2 years ago

Codecov Report

Merging #39 (bbd831e) into master (68b77fb) will decrease coverage by 3.2%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #39     +/-   ##
========================================
- Coverage    98.2%   95.0%   -3.2%     
========================================
  Files          18       6     -12     
  Lines        1215     480    -735     
  Branches        0     111    +111     
========================================
- Hits         1193     456    -737     
+ Misses         22      14      -8     
- Partials        0      10     +10     
Impacted Files Coverage Δ
access/raam.py 86.2% <0.0%> (-3.8%) :arrow_down:
access/helpers.py 96.3% <0.0%> (-3.7%) :arrow_down:
access/access.py 95.8% <0.0%> (-2.1%) :arrow_down:
access/__init__.py
access/tests/util.py
access/tests/test_hospital_example.py
access/tests/test_weights.py
access/tests/test_floating_catchment_area.py
access/tests/test_datasets.py
access/tests/test_raam.py
... and 5 more
jGaboardi commented 2 years ago

@JamesSaxon @martinfleis

I propose to update build_docs.yml so that it only builds when a fresh version tag is being pushed up. Thoughts? Shall I include it in this PR?

martinfleis commented 2 years ago

Shall I include it in this PR?

I'd leave it for another one.

jGaboardi commented 2 years ago

Shall I include it in this PR?

I'd leave it for another one.

👍 This PR is ready for review then.

jGaboardi commented 2 years ago

@JamesSaxon I'm going to and merging this. We can adjust/remove stuff later if it doesn't suit you (README badges, etc.).

JamesSaxon commented 2 years ago

Thanks @jGaboardi, I appreciate all your work.

I'm happy to follow standards of the org for the infrastructure stuff & formatting.