search

pysal / esda

statistics and classes for exploratory spatial data analysis
https://pysal.org/esda
BSD 3-Clause "New" or "Revised" License
206 stars 53 forks source link

Adjust imports to updates in `libpysal` #272

Closed jGaboardi closed 8 months ago

jGaboardi commented 8 months ago
codecov[bot] commented 8 months ago

Codecov Report

Merging #272 (2aba5ae) into main (3f5ce84) will increase coverage by 0.0%. The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #272   +/-   ##
=====================================
  Coverage   73.4%   73.4%           
=====================================
  Files         24      24           
  Lines       3284    3285    +1     
  Branches     518     518           
=====================================
+ Hits        2410    2411    +1     
  Misses       708     708           
  Partials     166     166
Files Coverage Δ
esda/getisord.py 67.1% <100.0%> (+0.1%) :arrow_up:
esda/smoothing.py 58.3% <100.0%> (ø)
martinfleis commented 8 months ago

We will need to release this before the next lib will come. Just a note.

jGaboardi commented 8 months ago

Any blockers at the moment? No time like the present.

martinfleis commented 8 months ago

We could easily do a patch just with this but also can wait. I don't assume lib will have a next release before end of the year.

jGaboardi commented 8 months ago

So would it hurt to have an esda=2.5.1 release? I can trigger that if so. But also, would it hurt to have a libpysal=4.8.1?

martinfleis commented 8 months ago

So would it hurt to have an esda=2.5.1 release?

no, better be ready.

But also, would it hurt to have a libpysal=4.8.1?

no need for that, we're not fixing anything a user would care about

jGaboardi commented 8 months ago

Done.