failing tests (numpy outputting data type in addition to the value)

pysal / giddy

Exploratory spatiotemporal data analysis and Geospatial distribution dynamics analysis

http://pysal.org/giddy/

BSD 3-Clause "New" or "Revised" License

76 stars 25 forks source link

failing tests (numpy outputting data type in addition to the value) #218

Closed weikang9009 closed 4 months ago

weikang9009 commented 5 months ago

The tests are failing https://github.com/pysal/giddy/actions/runs/9648038464/job/26608252448#step:7:194

It seems to be due to the changed behavior of the output of numpy - in addition to outputting the value, the data type is output as well. Any thoughts on resolving this?

sjsrey commented 5 months ago

It is due to the updated numpy: https://github.com/pysal/giddy/actions/runs/9648038464/job/26608252448#step:5:208

jGaboardi commented 5 months ago

Yeah, it affects the doctests:

So for spaghetti, I simply updated the expected output for those failing tests.

weikang9009 commented 5 months ago

I see. Thank you!

martinfleis commented 5 months ago

The only thing that changed is the __repr__ of numpy dtypes. These were always numpy objects, you just couldn't tell from the notebook output.