search

pysal / gwr

This is a repository for the geographically-weighted regression submodule of the Python Spatial Analysis Library
BSD 2-Clause "Simplified" License
16 stars 16 forks source link

Solving divided by zero issue #21

Closed Ziqi-Li closed 6 years ago

Ziqi-Li commented 6 years ago

Related to #9. Here is a notebook regarding @mattwigway 's dataset after implementing this PR.

Ziqi-Li commented 6 years ago

Sorry for the excessive commits, wondering how to squash them into one.

ljwolf commented 6 years ago

I use git rebase -i HEAD~k where k is the number of commits I want to move back.

Then, it'll pop you down into the rebase editor, where you get the option of picking what options you want for each commit. It should look like this, but if you've done it right, you should have all the commits line by line, like this: capture

Ziqi-Li commented 6 years ago

Made some comments to make it easier to review.

TaylorOshan commented 6 years ago

We've reached a consensus that this should be a sufficient solution for the divide-by-zero problem.