pysal / gwr

This is a repository for the geographically-weighted regression submodule of the Python Spatial Analysis Library
BSD 2-Clause "Simplified" License
16 stars 16 forks source link

GWR speed-up #4

Closed Ziqi-Li closed 6 years ago

Ziqi-Li commented 6 years ago

Two speed-up ideas

  1. Calculate only AIC/AICc/BIC/CV (search method) in bandwidth searching and calculate full diagnostics in the final GWR.fit(). I am planning to submit a PR about this.

  2. When calculating kernel for each bandwidth, distance matrix is calculated and sorted (if fixed = False) every time, which can be calculated for only once and passed to kernel calculation function.

TaylorOshan commented 6 years ago

Part 1 of this issue is addressed in #8 but was ultimately taken left for a future PR after some profiling.

Part 2 was satisfied in #10