Closed sjsrey closed 1 month ago
(note to self: continue to always check for 'pending' status on reviews moving forward)
(also, i think you started the schutz branch from your atkinson branch, so this commit includes both additions). Can probably close #74
Seems like we need to increase the timeout on the testing workflow. There Mac and Windows aren't finish within 30 minutes, but they almost are...
Probably bumping to 35 minutes should do the trick.
kinda taking awile for not a ton of functionality. Have we turned on parallel tests here yet?
The timeout comes only on Mac and Win and only in this PR. Given ubuntu runs in under a minute, I smell some issue related to non-linux runtime of something in this PR. If that is the case, bumping the timeout is probably not the optimal solution but we should figure out what is causing so massive performance difference.
My suspicion has to do with some tests I added for the plots. Trying to get the blessing of the codecov gods, I added some tests to cover, well everything. When I run them locally, separate windows actually get generated locally now (just noticed this this morning). I'm at a loss as to why linux can handle this, but not macos or windows on the ci. But I can revisit the tests to make them less troublesome.
kinda taking awile for not a ton of functionality. Have we turned on parallel tests here yet?
pytest-xdist
is enabled
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
[![Impacted file tree graph](https://app.codecov.io/gh/pysal/inequality/pull/75/graphs/tree.svg?width=650&height=150&src=pr&token=LJmAqzGxV5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)](https://app.codecov.io/gh/pysal/inequality/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #75 +/- ## ======================================= + Coverage 96.3% 96.7% +0.4% ======================================= Files 5 7 +2 Lines 433 491 +58 ======================================= + Hits 417 475 +58 Misses 16 16 ``` | [Files with missing lines](https://app.codecov.io/gh/pysal/inequality/pull/75?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) | Coverage Δ | | |---|---|---| | [inequality/\_\_init\_\_.py](https://app.codecov.io/gh/pysal/inequality/pull/75?src=pr&el=tree&filepath=inequality%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-aW5lcXVhbGl0eS9fX2luaXRfXy5weQ==) | `100.0% <100.0%> (ø)` | | | [inequality/atkinson.py](https://app.codecov.io/gh/pysal/inequality/pull/75?src=pr&el=tree&filepath=inequality%2Fatkinson.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-aW5lcXVhbGl0eS9hdGtpbnNvbi5weQ==) | `100.0% <100.0%> (ø)` | | | [inequality/schutz.py](https://app.codecov.io/gh/pysal/inequality/pull/75?src=pr&el=tree&filepath=inequality%2Fschutz.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-aW5lcXVhbGl0eS9zY2h1dHoucHk=) | `100.0% <100.0%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/pysal/inequality/pull/75/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)