search

pysal / libpysal

Core components of Python Spatial Analysis Library
http://pysal.org/libpysal
Other
249 stars 79 forks source link

Release coordination #631

Open martinfleis opened 8 months ago

martinfleis commented 8 months ago

Recent changes that made it to 4.9.2 caused a lot of trouble at many places.

Considering all of this, I believe that we need to put in place additional checks before making a release of libpysal. A subset of that could be also applied elsewhere, to ensure that we don't break our own ecosystem.

knaaptime commented 8 months ago

as a first cut, we should probably make sure that all the subpackages test against libpysal@main (like esda), and that downstream tests pass before a new libpysal is released

knaaptime commented 8 months ago

we have not updated requirements on conda-forge (https://github.com/conda-forge/libpysal-feedstock/pull/23) which resulted in 4.9.2 being installed in Python 3.9 and 3.8. environments while being incompatible with those

i think the other way to handle this is to turn off automerge. While i like automerge, there's no way to control something like the minimum dependency change we just encountered (unless you catch the recipe PR before the bot merges). When we issue a new release, the CI can guarantee the dependencies are correct in the source code, but theres no way to force the conda-forge recipe to use those deps

martinfleis commented 8 months ago

Automerge wasn't on.

jGaboardi commented 8 months ago

This specific time did not have to do with automerge, unfortunately. The PR passed, so I merged it 😞.

knaaptime commented 8 months ago

(but its turned on now)

EDIT: actually, is it? its defined twice in here

martinfleis commented 8 months ago

Ah, my bad! Then it probably was on and I just missed it. The PR was merged manually though.