pysal / libpysal

Core components of Python Spatial Analysis Library
http://pysal.org/libpysal
Other
259 stars 78 forks source link

Migration guide W->Graph #712

Closed sjsrey closed 2 months ago

sjsrey commented 4 months ago

Two teaching materials where one is derived from the other and updated to use Graph instead of W.

Apart from the different datasets, it is nearly 1:1 and can be used as a basis of the migration guide.

edited by @martinfleis

knaaptime commented 3 months ago

following the discussion from the June dev meeting, we want to open a discussion about Graph nomenclature (specifically when you need to work with multiple graphs simultaneously e.g. from libpysal and networkx at once) it might be easier to rename Graph to GeoGraph or similar. Opening here for discussion so we can vote in the next dev meeting

martinfleis commented 3 months ago

I am tentatively for the renaming as it is going to be clearer to the user what is required where and avoids some confusion between different graph representations. But I also don't feel super strongly about this. It's also going to break some of my research code and teaching materials but I can deal with that easily.

jGaboardi commented 3 months ago

xref: https://github.com/pysal/momepy/issues/579

I have no strong opinions either way, so probably not a bad to go with the more distinctive GeoGraph. Wasn't GeoGraph the original name that was under consideration when the refactor first started out?

martinfleis commented 3 months ago

Existence of this https://geograph.readthedocs.io/en/latest/ may affect the decision here...

jGaboardi commented 3 months ago

Are there any other alternative names being thrown around?

knaaptime commented 3 months ago

at the steering committee meeting this morning we voted to keep Graph for the time being

jGaboardi commented 2 months ago

complete via #733