search

pysal / libpysal

Core components of Python Spatial Analysis Library
http://pysal.org/libpysal
Other
249 stars 79 forks source link

COMPAT: remove typing from Graph.describe #719

Closed martinfleis closed 3 weeks ago

martinfleis commented 4 weeks ago

We don't use types anywhere in the module and these were also using deprecated numpy dtype. Removing for consistency.

Fixes https://github.com/pysal/mapclassify/issues/214

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.1%. Comparing base (bcabdbc) to head (c14f583). Report is 21 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pysal/libpysal/pull/719/graphs/tree.svg?width=650&height=150&src=pr&token=wgnkG5Rj0J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)](https://app.codecov.io/gh/pysal/libpysal/pull/719?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #719 +/- ## ======================================= + Coverage 85.0% 85.1% +0.1% ======================================= Files 141 145 +4 Lines 15203 15567 +364 ======================================= + Hits 12924 13252 +328 - Misses 2279 2315 +36 ``` | [Files](https://app.codecov.io/gh/pysal/libpysal/pull/719?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) | Coverage Δ | | |---|---|---| | [libpysal/graph/base.py](https://app.codecov.io/gh/pysal/libpysal/pull/719?src=pr&el=tree&filepath=libpysal%2Fgraph%2Fbase.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bGlicHlzYWwvZ3JhcGgvYmFzZS5weQ==) | `96.8% <ø> (-1.1%)` | :arrow_down: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/pysal/libpysal/pull/719/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)