search

pysal / libpysal

Core components of Python Spatial Analysis Library
http://pysal.org/libpysal
Other
259 stars 78 forks source link

ENH: pass kwargs to buffer in fuzzy_contiguity #720

Closed martinfleis closed 3 months ago

martinfleis commented 3 months ago

When using fuzzy_contiguity with a buffer, it may be worth using a lower resolution to speed up the computation. This enables passing kwargs to buffer to allow this type of control.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.1%. Comparing base (bcabdbc) to head (842d5d9). Report is 24 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pysal/libpysal/pull/720/graphs/tree.svg?width=650&height=150&src=pr&token=wgnkG5Rj0J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)](https://app.codecov.io/gh/pysal/libpysal/pull/720?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #720 +/- ## ======================================= + Coverage 85.0% 85.1% +0.1% ======================================= Files 141 145 +4 Lines 15203 15576 +373 ======================================= + Hits 12924 13257 +333 - Misses 2279 2319 +40 ``` | [Files](https://app.codecov.io/gh/pysal/libpysal/pull/720?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) | Coverage Δ | | |---|---|---| | [libpysal/graph/\_contiguity.py](https://app.codecov.io/gh/pysal/libpysal/pull/720?src=pr&el=tree&filepath=libpysal%2Fgraph%2F_contiguity.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bGlicHlzYWwvZ3JhcGgvX2NvbnRpZ3VpdHkucHk=) | `98.9% <100.0%> (+<0.1%)` | :arrow_up: | | [libpysal/graph/base.py](https://app.codecov.io/gh/pysal/libpysal/pull/720?src=pr&el=tree&filepath=libpysal%2Fgraph%2Fbase.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bGlicHlzYWwvZ3JhcGgvYmFzZS5weQ==) | `96.8% <ø> (-1.1%)` | :arrow_down: | | [libpysal/graph/tests/test\_builders.py](https://app.codecov.io/gh/pysal/libpysal/pull/720?src=pr&el=tree&filepath=libpysal%2Fgraph%2Ftests%2Ftest_builders.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bGlicHlzYWwvZ3JhcGgvdGVzdHMvdGVzdF9idWlsZGVycy5weQ==) | `100.0% <100.0%> (ø)` | | | [libpysal/graph/tests/test\_contiguity.py](https://app.codecov.io/gh/pysal/libpysal/pull/720?src=pr&el=tree&filepath=libpysal%2Fgraph%2Ftests%2Ftest_contiguity.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bGlicHlzYWwvZ3JhcGgvdGVzdHMvdGVzdF9jb250aWd1aXR5LnB5) | `100.0% <100.0%> (ø)` | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/pysal/libpysal/pull/720/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)
martinfleis commented 3 months ago

Is this in support of https://github.com/pysal/momepy/pull/598#issuecomment-2167256852?

@jGaboardi yes