Open sjsrey opened 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.2%. Comparing base (
bcabdbc
) to head (3c938c1
). Report is 39 commits behind head on main.
sweet
I like that automatic comparison but in some cases, it may be worth adding a note explaining why there's no match and what is recommended to do instead. E.g Graph does not have islands
but has isolates
instead etc.
I also suppose that merge shall wait until the notebook is complete, right?
I like that automatic comparison but in some cases, it may be worth adding a note explaining why there's no match and what is recommended to do instead. E.g Graph does not have
islands
but hasisolates
instead etc.
Yes, this was intended to identify all the cases we need to surface in the recommendations. I wasn't sure if we should put the recommendations in these tables, or treat them in the migration notebook where we can have a bit more narrative for the user.
I also suppose that merge shall wait until the notebook is complete, right?
Definitely.
treat them in the migration notebook where we can have a bit more narrative for the user.
That may be better. We just need to make a link to the notebook clear and visible from the RST with the tables.
This is a start towards addressing #712. Seeking feedback and discussion.
It will add a note to the index page:
This also adds a dynamically generated rst file that will report on the members for W and Graph, which is the target of the note.
In addition, I will add a notebook that builds on the suggestions in #712 to have more of a user facing orientation.
This is intended to be dynamic and assist us as we fully build out the
Graph
moving forward.Once we are done with the transition, we can remove this dynamically generated rst file, if so desired.