pysal / mapclassify

Classification schemes for choropleth mapping.
https://pysal.org/mapclassify
BSD 3-Clause "New" or "Revised" License
139 stars 32 forks source link

lint code base with `ruff` #195

Closed jGaboardi closed 1 year ago

jGaboardi commented 1 year ago

This PR resolves #185

codecov[bot] commented 1 year ago

Codecov Report

Merging #195 (aa2f44c) into main (7223042) will decrease coverage by 0.1%. The diff coverage is 87.1%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #195     +/-   ##
=======================================
- Coverage   88.8%   88.7%   -0.1%     
=======================================
  Files          8       8             
  Lines       1112    1107      -5     
=======================================
- Hits         987     982      -5     
  Misses       125     125             
Files Changed Coverage Δ
mapclassify/greedy.py 92.1% <40.0%> (ø)
mapclassify/classifiers.py 88.1% <96.0%> (-0.1%) :arrow_down:
mapclassify/pooling.py 84.2% <100.0%> (ø)
jGaboardi commented 1 year ago

Also, the release action is being triggered for these CI runs. Need to get that under control.

jGaboardi commented 1 year ago

Also, the release action is being triggered for these CI runs. Need to get that under control.

There was a syntax error in .github/workflows/release.yml resulting a failed evaluation; it was not actually being triggered.

@martinfleis Is this ready to merge following this next passing CI?