Closed virgilxw closed 3 months ago
Thanks for the report. It is probably caused by improperly noded network. See this blogpost for details.
We should add an option to do noding prior polygonization in enclosures creation, probably defaulting to True. There was a similar discussion on geopandas / shapely sides to include noding in polygonization on lower level as well but we can do it here manually before that.
problem still persists. There are definitely issues tesselating limits that are multipolygons with empty spaces within.
Any chance you could provide a minimal reproducible example? The link above leads to 404 and I would need to be able to reproduce the issue to figure out what is wrong.
minimally reproducible example here: https://github.com/virgilxw/momepy-test/blob/b7ad44841f7f49791b060723f977968ce29d0611/processor/github_error_submission.ipynb
Sorry for a late response. However, that notebook is not a minimal reproducible example as it links to data I don't have access to (and don't want to as it will be large). Can you try to craft an example alongside this guide?
Closing as I currently cannot act on this due to missing reproducible example.
Describe the problem
I was using osmnx to generate a street network alongside a boundary shapefile. The enclosures came out malformed with many overlaps, causing problems when finding queen contiguity.
Steps to reproduce
The script that causes the problem can be found at https://github.com/virgilxw/momepy-test/blob/main/1-%20osmnx%20download.ipynb
It has been tested on two computers
Versions of your packages
Your operating system
No response
Additional context
No response