search

pysal / momepy

Urban Morphology Measuring Toolkit
https://docs.momepy.org
BSD 3-Clause "New" or "Revised" License
496 stars 59 forks source link

REF: Simplify list and dict manipulation #493

Closed eumiro closed 1 year ago

eumiro commented 1 year ago

Only straightforward refactoring, no tests/functionality affected.

codecov[bot] commented 1 year ago

Codecov Report

Merging #493 (0ccbdc7) into main (130ddfd) will increase coverage by 0.2%. The diff coverage is 90.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #493     +/-   ##
=======================================
+ Coverage   97.2%   97.5%   +0.2%     
=======================================
  Files         24      24             
  Lines       4156    4126     -30     
=======================================
- Hits        4041    4022     -19     
+ Misses       115     104     -11
Impacted Files Coverage Δ
momepy/preprocessing.py 93.7% <80.0%> (+2.3%) :arrow_up:
momepy/coins.py 95.4% <100.0%> (-<0.1%) :arrow_down:
momepy/diversity.py 98.8% <100.0%> (-<0.1%) :arrow_down:
momepy/utils.py 99.4% <100.0%> (-<0.1%) :arrow_down:
jGaboardi commented 1 year ago

@eumiro Thank you for your contribution!

@martinfleis This way is much cleaner. Do we think there is a reason keeping the original, more verbose implementation?

martinfleis commented 1 year ago

No reason. I was young and didn't know what I was doing :D.