pysal / momepy

Urban Morphology Measuring Toolkit
https://docs.momepy.org
BSD 3-Clause "New" or "Revised" License
496 stars 59 forks source link

notes on plans with the rest of dimension classes #536

Closed martinfleis closed 7 months ago

martinfleis commented 10 months ago

This is more a discussion than actual PR. I went through dimension.py and thought about the future of all of the classes we have there. There are two main questions

  1. Do we keep these as thin wrappers around Graph.lag or point directly to lag?
  2. What should be moved to libpysal and how?
codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.7%. Comparing base (29c0e5d) to head (b38fa2e). Report is 19 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pysal/momepy/pull/536/graphs/tree.svg?width=650&height=150&src=pr&token=VNn0WR5JWT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)](https://app.codecov.io/gh/pysal/momepy/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #536 +/- ## ======================================= + Coverage 97.5% 97.7% +0.2% ======================================= Files 26 32 +6 Lines 4189 4996 +807 ======================================= + Hits 4086 4882 +796 - Misses 103 114 +11 ``` | [Files](https://app.codecov.io/gh/pysal/momepy/pull/536?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) | Coverage Δ | | |---|---|---| | [momepy/dimension.py](https://app.codecov.io/gh/pysal/momepy/pull/536?src=pr&el=tree&filepath=momepy%2Fdimension.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2RpbWVuc2lvbi5weQ==) | `98.7% <ø> (ø)` | | ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/pysal/momepy/pull/536/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)
martinfleis commented 7 months ago

I am going to merge this to keep the notes in sync with the development