search

pysal / momepy

Urban Morphology Measuring Toolkit
https://docs.momepy.org
BSD 3-Clause "New" or "Revised" License
495 stars 59 forks source link

ENH: refactor tessellation #559

Closed martinfleis closed 8 months ago

martinfleis commented 8 months ago

WIP but the code works already.

For morphological tessellation:

new: 8min 43s
old: 27min 8s

For enclosed tessellation:

    # Old with Dask
    # CPU times: user 10.5 s, sys: 1.57 s, total: 12.1 s
    # Wall time: 6min 36s

    # New n_jobs=1
    # CPU times: user 2min 48s, sys: 547 ms, total: 2min 48s
    # Wall time: 2min 50s

    # New n_jobs=-1
    # CPU times: user 7.11 s, sys: 857 ms, total: 7.97 s
    # Wall time: 46.2 s
codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 98.38710% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.7%. Comparing base (4037c70) to head (705eb7f). Report is 8 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pysal/momepy/pull/559/graphs/tree.svg?width=650&height=150&src=pr&token=VNn0WR5JWT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)](https://app.codecov.io/gh/pysal/momepy/pull/559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #559 +/- ## ======================================= + Coverage 97.4% 97.7% +0.3% ======================================= Files 26 32 +6 Lines 4328 4942 +614 ======================================= + Hits 4214 4826 +612 - Misses 114 116 +2 ``` | [Files](https://app.codecov.io/gh/pysal/momepy/pull/559?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) | Coverage Δ | | |---|---|---| | [momepy/\_\_init\_\_.py](https://app.codecov.io/gh/pysal/momepy/pull/559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L19faW5pdF9fLnB5) | `100.0% <100.0%> (ø)` | | | [momepy/functional/tests/test\_elements.py](https://app.codecov.io/gh/pysal/momepy/pull/559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvdGVzdHMvdGVzdF9lbGVtZW50cy5weQ==) | `100.0% <100.0%> (ø)` | | | [momepy/functional/\_elements.py](https://app.codecov.io/gh/pysal/momepy/pull/559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvX2VsZW1lbnRzLnB5) | `96.3% <96.3%> (ø)` | |