pysal / momepy

Urban Morphology Measuring Toolkit
https://docs.momepy.org
BSD 3-Clause "New" or "Revised" License
495 stars 59 forks source link

ENH: street_alignment and get_nearest_street #566

Closed martinfleis closed 7 months ago

martinfleis commented 7 months ago

I love how streamlined these things are now compared to the original :).

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.7%. Comparing base (4037c70) to head (02e9b54). Report is 11 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pysal/momepy/pull/566/graphs/tree.svg?width=650&height=150&src=pr&token=VNn0WR5JWT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)](https://app.codecov.io/gh/pysal/momepy/pull/566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #566 +/- ## ======================================= + Coverage 97.4% 97.7% +0.3% ======================================= Files 26 32 +6 Lines 4328 4985 +657 ======================================= + Hits 4214 4869 +655 - Misses 114 116 +2 ``` | [Files](https://app.codecov.io/gh/pysal/momepy/pull/566?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) | Coverage Δ | | |---|---|---| | [momepy/functional/\_distribution.py](https://app.codecov.io/gh/pysal/momepy/pull/566?src=pr&el=tree&filepath=momepy%2Ffunctional%2F_distribution.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvX2Rpc3RyaWJ1dGlvbi5weQ==) | `100.0% <100.0%> (ø)` | | | [momepy/functional/\_elements.py](https://app.codecov.io/gh/pysal/momepy/pull/566?src=pr&el=tree&filepath=momepy%2Ffunctional%2F_elements.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvX2VsZW1lbnRzLnB5) | `96.8% <100.0%> (ø)` | | | [momepy/functional/tests/test\_distribution.py](https://app.codecov.io/gh/pysal/momepy/pull/566?src=pr&el=tree&filepath=momepy%2Ffunctional%2Ftests%2Ftest_distribution.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvdGVzdHMvdGVzdF9kaXN0cmlidXRpb24ucHk=) | `100.0% <100.0%> (ø)` | | | [momepy/functional/tests/test\_elements.py](https://app.codecov.io/gh/pysal/momepy/pull/566?src=pr&el=tree&filepath=momepy%2Ffunctional%2Ftests%2Ftest_elements.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvdGVzdHMvdGVzdF9lbGVtZW50cy5weQ==) | `100.0% <100.0%> (ø)` | |
martinfleis commented 7 months ago

I'll do the typing consistency as a follow-up across the codebase.