Closed martinfleis closed 7 months ago
Attention: Patch coverage is 96.29630%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 97.7%. Comparing base (
4037c70
) to head (5b75742
). Report is 16 commits behind head on main.
How would you set the CI envs to test numba and fallback options? I am not a big fan of having everything twice. Would 1 env without numba be enough in your experience?
Yes, I think we can add a note to the README
, docs, and wherever else that we strongly encourage installing & using numba
. Then perhaps adding a 312-min.yml
to the matrix that doesn't include numba
.
Follow-up on #570
Had to reimplement
mode
to actually compile based on https://github.com/numba/numba/pull/2959#issuecomment-741715733.Timings compared to #570
How would you set the CI envs to test numba and fallback options? I am not a big fan of having everything twice. Would 1 env without numba be enough in your experience?