pysal / momepy

Urban Morphology Measuring Toolkit
https://docs.momepy.org
BSD 3-Clause "New" or "Revised" License
496 stars 59 forks source link

functional courtyards calculation #572

Closed u3ks closed 7 months ago

u3ks commented 7 months ago

Refactoring courtyards calculation to fit with the functional API and to speed it up.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.8%. Comparing base (4037c70) to head (47b1ee5). Report is 16 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pysal/momepy/pull/572/graphs/tree.svg?width=650&height=150&src=pr&token=VNn0WR5JWT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)](https://app.codecov.io/gh/pysal/momepy/pull/572?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #572 +/- ## ======================================= + Coverage 97.4% 97.8% +0.4% ======================================= Files 26 37 +11 Lines 4328 5144 +816 ======================================= + Hits 4214 5030 +816 Misses 114 114 ``` | [Files](https://app.codecov.io/gh/pysal/momepy/pull/572?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) | Coverage Δ | | |---|---|---| | [momepy/\_\_init\_\_.py](https://app.codecov.io/gh/pysal/momepy/pull/572?src=pr&el=tree&filepath=momepy%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L19faW5pdF9fLnB5) | `100.0% <100.0%> (ø)` | | | [momepy/functional/\_intensity.py](https://app.codecov.io/gh/pysal/momepy/pull/572?src=pr&el=tree&filepath=momepy%2Ffunctional%2F_intensity.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvX2ludGVuc2l0eS5weQ==) | `100.0% <100.0%> (ø)` | | | [momepy/functional/tests/test\_intensity.py](https://app.codecov.io/gh/pysal/momepy/pull/572?src=pr&el=tree&filepath=momepy%2Ffunctional%2Ftests%2Ftest_intensity.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvdGVzdHMvdGVzdF9pbnRlbnNpdHkucHk=) | `100.0% <100.0%> (ø)` | |
u3ks commented 7 months ago

Timings:

new time: 11.6 s ± 191 ms per loop (mean ± std. dev. of 7 runs, 1 loop each) old time: 43.8 s ± 635 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)