pysal / momepy

Urban Morphology Measuring Toolkit
https://docs.momepy.org
BSD 3-Clause "New" or "Revised" License
478 stars 58 forks source link

BUG/ENH: support custom enclosure index is in tessellation and GeoDataFrame as enclosure input #582

Closed martinfleis closed 4 months ago

martinfleis commented 4 months ago

The indexing was broken for non-default RangeIndex. Also, given we currently return enclosures as gdf, it is handy to support it out of the box.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.8%. Comparing base (4037c70) to head (029d987). Report is 83 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pysal/momepy/pull/582/graphs/tree.svg?width=650&height=150&src=pr&token=VNn0WR5JWT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)](https://app.codecov.io/gh/pysal/momepy/pull/582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #582 +/- ## ======================================= + Coverage 97.4% 97.8% +0.5% ======================================= Files 26 37 +11 Lines 4328 5362 +1034 ======================================= + Hits 4214 5246 +1032 - Misses 114 116 +2 ``` | [Files](https://app.codecov.io/gh/pysal/momepy/pull/582?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) | Coverage Δ | | |---|---|---| | [momepy/functional/\_elements.py](https://app.codecov.io/gh/pysal/momepy/pull/582?src=pr&el=tree&filepath=momepy%2Ffunctional%2F_elements.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvX2VsZW1lbnRzLnB5) | `100.0% <100.0%> (ø)` | | | [momepy/functional/tests/test\_elements.py](https://app.codecov.io/gh/pysal/momepy/pull/582?src=pr&el=tree&filepath=momepy%2Ffunctional%2Ftests%2Ftest_elements.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvdGVzdHMvdGVzdF9lbGVtZW50cy5weQ==) | `100.0% <100.0%> (ø)` | |