pysal / momepy

Urban Morphology Measuring Toolkit
https://docs.momepy.org
BSD 3-Clause "New" or "Revised" License
465 stars 56 forks source link

Tess simplification #595

Open u3ks opened 1 month ago

u3ks commented 1 month ago

Adding the option to simplify the enclosed tessellations & a filtering fix

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 30.76923% with 18 lines in your changes missing coverage. Please review.

Project coverage is 97.9%. Comparing base (4037c70) to head (2d1bfb9). Report is 72 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pysal/momepy/pull/595/graphs/tree.svg?width=650&height=150&src=pr&token=VNn0WR5JWT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)](https://app.codecov.io/gh/pysal/momepy/pull/595?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #595 +/- ## ======================================= + Coverage 97.4% 97.9% +0.5% ======================================= Files 26 38 +12 Lines 4328 6278 +1950 ======================================= + Hits 4214 6145 +1931 - Misses 114 133 +19 ``` | [Files](https://app.codecov.io/gh/pysal/momepy/pull/595?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) | Coverage Δ | | |---|---|---| | [momepy/functional/\_elements.py](https://app.codecov.io/gh/pysal/momepy/pull/595?src=pr&el=tree&filepath=momepy%2Ffunctional%2F_elements.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvX2VsZW1lbnRzLnB5) | `96.9% <57.1%> (ø)` | | | [momepy/functional/tests/test\_elements.py](https://app.codecov.io/gh/pysal/momepy/pull/595?src=pr&el=tree&filepath=momepy%2Ffunctional%2Ftests%2Ftest_elements.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2Z1bmN0aW9uYWwvdGVzdHMvdGVzdF9lbGVtZW50cy5weQ==) | `92.3% <21.1%> (ø)` | |
martinfleis commented 4 weeks ago

Please split simplification and the fix into two distinct PRs. The former will wait until we get shapely.coverage_simplify merged, while the latter shall be merged now.