Closed jGaboardi closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.0%. Comparing base (
4037c70
) to head (8c91d28
). Report is 85 commits behind head on main.
On the categories, something like
- API changes
- Enhancements
- Bug fixes
- Deprecations
- Documentation
- Other
? I am not a fan of having type (e.g. enhancement) and content (e.g. preprocessing) mixed together. I also don't think that refactoring needs to be included as it should not affect user in any way.
So maybe like:
refactor
?enhancements
bug
documentation
*
The thing is that we don't have labels for all and will have go back through all Issues & PRs to add those new labels once they are created. @martinfleis
The thing is that we don't have labels for all and will have go back through all Issues & PRs to add those new labels once they are created
I am happy to do that.
refactor
? - refactor is not API change. API change is stuff like change of a default arg value. We don't have a label for that and we haven't done any API changes. All stuff regarding the API model is considered enhancement as those are new functions that live alongside the old.enhancements
bug
deprecation
documentation
*
refactor is not API change. API change is stuff like change of a default arg value. We don't have a label for that and we haven't done any API changes. All stuff regarding the API model is considered enhancement as those are new functions that live alongside the old.
Roger that. OK, I'll add api
and deprecation
labels within release.yml
then go ahead and create those labels in the repo.
@martinfleis this is ready for review. once merged I will see about a tag + release of v0.8.0-alpha1
Same osmnx
error causing failures -- https://github.com/pysal/momepy/actions/runs/9530670355/job/26270797522?pr=604#step:5:544
gha for release notes - #543
spopt
and the one here inmomepy
differ considerably -- will have to see how adding the "create release notes" interacts here