pysal / momepy

Urban Morphology Measuring Toolkit
https://docs.momepy.org
BSD 3-Clause "New" or "Revised" License
478 stars 58 forks source link

gha for release notes - #543 #604

Closed jGaboardi closed 3 months ago

jGaboardi commented 3 months ago

gha for release notes - #543

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.0%. Comparing base (4037c70) to head (8c91d28). Report is 85 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pysal/momepy/pull/604/graphs/tree.svg?width=650&height=150&src=pr&token=VNn0WR5JWT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)](https://app.codecov.io/gh/pysal/momepy/pull/604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #604 +/- ## ======================================= + Coverage 97.4% 98.0% +0.6% ======================================= Files 26 37 +11 Lines 4328 6068 +1740 ======================================= + Hits 4214 5946 +1732 - Misses 114 122 +8 ```
jGaboardi commented 3 months ago

On the categories, something like

  • API changes
  • Enhancements
  • Bug fixes
  • Deprecations
  • Documentation
  • Other

? I am not a fan of having type (e.g. enhancement) and content (e.g. preprocessing) mixed together. I also don't think that refactoring needs to be included as it should not affect user in any way.

So maybe like:

The thing is that we don't have labels for all and will have go back through all Issues & PRs to add those new labels once they are created. @martinfleis

martinfleis commented 3 months ago

The thing is that we don't have labels for all and will have go back through all Issues & PRs to add those new labels once they are created

I am happy to do that.

jGaboardi commented 3 months ago

refactor is not API change. API change is stuff like change of a default arg value. We don't have a label for that and we haven't done any API changes. All stuff regarding the API model is considered enhancement as those are new functions that live alongside the old.

Roger that. OK, I'll add api and deprecation labels within release.yml then go ahead and create those labels in the repo.

jGaboardi commented 3 months ago

@martinfleis this is ready for review. once merged I will see about a tag + release of v0.8.0-alpha1

jGaboardi commented 3 months ago

Same osmnx error causing failures -- https://github.com/pysal/momepy/actions/runs/9530670355/job/26270797522?pr=604#step:5:544