pysal / momepy

Urban Morphology Measuring Toolkit
https://docs.momepy.org
BSD 3-Clause "New" or "Revised" License
496 stars 59 forks source link

[COINS] Fix angle between lines #630

Closed fnattino closed 5 months ago

fnattino commented 5 months ago

Giving it a try to a version that simplifies the calculation of angles between the line segments.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.1%. Comparing base (4037c70) to head (f02ea9e). Report is 63 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pysal/momepy/pull/630/graphs/tree.svg?width=650&height=150&src=pr&token=VNn0WR5JWT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)](https://app.codecov.io/gh/pysal/momepy/pull/630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #630 +/- ## ======================================= + Coverage 97.4% 98.1% +0.8% ======================================= Files 26 38 +12 Lines 4328 6200 +1872 ======================================= + Hits 4214 6084 +1870 - Misses 114 116 +2 ``` | [Files](https://app.codecov.io/gh/pysal/momepy/pull/630?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) | Coverage Δ | | |---|---|---| | [momepy/tests/test\_coins.py](https://app.codecov.io/gh/pysal/momepy/pull/630?src=pr&el=tree&filepath=momepy%2Ftests%2Ftest_coins.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L3Rlc3RzL3Rlc3RfY29pbnMucHk=) | `100.0% <100.0%> (ø)` | | | [momepy/coins.py](https://app.codecov.io/gh/pysal/momepy/pull/630?src=pr&el=tree&filepath=momepy%2Fcoins.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-bW9tZXB5L2NvaW5zLnB5) | `99.5% <93.3%> (+4.2%)` | :arrow_up: |
martinfleis commented 5 months ago

@anastassiavybornova could you review this one please?

anastassiavybornova commented 5 months ago

@martinfleis yes will do