search

pysal / notebooks

jupyter/ipython notebooks demonstrating PySAL functionality
53 stars 38 forks source link

test that notebook run #82

Open knaaptime opened 4 years ago

knaaptime commented 4 years ago

the current CI setup tests that the book builds, but does not test that it actually runs, which can be super confusing to users if our canonical tutorials have trouble running. Once #81 is addressed, it would be trivial to make sure that notebooks run using nconvert in thew travis config

darribas commented 4 years ago

+1!!! Checking, it might actually be very straightforward, as the CL tool already allows for execution of notebooks:

https://github.com/pysal/notebooks/blob/c86bd663efb473e3e3186bb5413bb8845fa31cbd/lib/build.py#L246-L247

So should be a switch on the CI only. Not sure if they'll be too heavy to run every single time, but at the very least we should enforce the practice of making sure the pass locally.