search

pysal / notebooks

jupyter/ipython notebooks demonstrating PySAL functionality
53 stars 38 forks source link

ENH: Makefile for development #92

Open sjsrey opened 4 years ago

sjsrey commented 4 years ago

The current README instructions has the docker container not returning a shell for entry but rather the lab is running. It isn't clear how to move onto the build steps from that point.

The Makefile here is intended to support either running the lab in the container w/o a shell, or getting as shell.

darribas commented 4 years ago

Hey! Thanks for this. My approach has been to launch JupyterLab on a container and then run all the commands to build the website, etc. from inside JupyterLab (on a terminal window, which is equivalent to launching the container with start.sh, but lets you also edit files and try notebooks out). My thinking in that is that if someone is not using a container but has all the dependencies installed locally, they should be able to replicate it too and it doesn't lock them on using Docker.

But it is true that this could be better documented, would it make sense to try to expand on this a bit in the README.md?