fix error and API for quadrat based statistics

pysal / pointpats

Planar Point Pattern Analysis in PySAL

https://pysal.org/pointpats/

BSD 3-Clause "New" or "Revised" License

80 stars 26 forks source link

fix error and API for quadrat based statistics #104

Closed weikang9009 closed 1 year ago

weikang9009 commented 1 year ago

This PR is to fix an error and missing attributes for quadrat-based statistics:

and should be used instead of & as the logical operator between two float numbers
rectangle_width and rectangle_height are attributes of RectangleM but are missing in the docstrings
add positional arguments rectangle_width and rectangle_height to the constructor method of QStatistic to allow users to pass width and height of the grid cells in addition to the number of cells

codecov[bot] commented 1 year ago

Codecov Report

Merging #104 (b987685) into main (af7ac57) will increase coverage by 0.27%. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   52.47%   52.74%   +0.27%     
==========================================
  Files          12       12              
  Lines        1841     1841              
  Branches      315      315              
==========================================
+ Hits          966      971       +5     
+ Misses        819      815       -4     
+ Partials       56       55       -1

Impacted Files	Coverage Δ
pointpats/quadrat_statistics.py	`59.13% <75.00%> (+2.68%)`	:arrow_up:

ljwolf commented 1 year ago

Good fix @weikang9009!