Closed ljwolf closed 10 months ago
@ljwolf Thanks for fixing this! It seems that test_j()
did not pass?
Yep, still working. Wait til the tests pass to merge 😄 I will ping when this is ready for review!
@ljwolf do you think this could make it to the next meta? We need to cut a release anyway due to #107 so it would be nice to clean these deprecations at the same time.
We'll also need to sync this and #109 but I can update #109 easily once this is in.
Merging #105 (f359648) into main (de0470a) will increase coverage by
7.04%
. Report is 2 commits behind head on main. The diff coverage is73.07%
.
@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 52.56% 59.61% +7.04%
==========================================
Files 12 10 -2
Lines 1851 1404 -447
Branches 317 246 -71
==========================================
- Hits 973 837 -136
+ Misses 821 517 -304
+ Partials 57 50 -7
Files Changed | Coverage Δ | |
---|---|---|
pointpats/distance_statistics.py | 72.77% <68.18%> (-2.23%) |
:arrow_down: |
pointpats/process.py | 20.18% <100.00%> (-28.90%) |
:arrow_down: |
pointpats/window.py | 68.00% <100.00%> (-1.57%) |
:arrow_down: |
This addresses a few of the recent issues filed (#100 #101 #83). The shaping issue was caused by premature truncation for the
j()
function when runningj_test()
. Forj_test()
, we need to keep all support values of thej()
function until the end, and then truncate.The other superfluous files, such as
ripley.py
and deprecated statistics, are removed, too.