While doing that, I noticed that the new implementation seems to live in distance_statistics.py but then we have nearly exactly the same code also in ripley.py.
distance_statistics.py has more complete docstrings and is included in API docs, while ripley.py has some additional utils.
The distance_statistics.ipynb notebooks will also need to be updated to point to new functions from the deprecated classes.
@ljwolf I suppose you will know the answers. I thought that the contents of ripley.py has been moved to distance_statistics.py and never removed from the original location but there are more recent comments to ripley.py than to distance_statistics.py so I am a bit confused.
martinfleis
commented
1 year ago
Hey,
I wanted to remove old deprecated classes Ripley's functions that are now in
_deprecated_distance_statistics.py`.While doing that, I noticed that the new implementation seems to live in
distance_statistics.pybut then we have nearly exactly the same code also inripley.py.distance_statistics.pyhas more complete docstrings and is included in API docs, whileripley.pyhas some additional utils.Is it safe to remove ripley.py from the codebase? It is not tested (0% coverage) but it is used in the distance_statistics-numpy-oriented.ipynb notebook.
The distance_statistics.ipynb notebooks will also need to be updated to point to new functions from the deprecated classes.
@ljwolf I suppose you will know the answers. I thought that the contents of ripley.py has been moved to distance_statistics.py and never removed from the original location but there are more recent comments to ripley.py than to distance_statistics.py so I am a bit confused.