pysal / pointpats

Planar Point Pattern Analysis in PySAL
https://pysal.org/pointpats/
BSD 3-Clause "New" or "Revised" License
80 stars 26 forks source link

Add symmetric st-neighbors in local knox #121

Closed sjsrey closed 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

Merging #121 (38b5c11) into main (a9d384c) will increase coverage by 5.3%. Report is 4 commits behind head on main. The diff coverage is 93.5%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #121     +/-   ##
=======================================
+ Coverage   64.1%   69.4%   +5.3%     
=======================================
  Files         12      12             
  Lines       1448    1769    +321     
=======================================
+ Hits         928    1228    +300     
- Misses       520     541     +21     
Files Coverage Δ
pointpats/spacetime.py 93.3% <93.5%> (+0.2%) :arrow_up:

... and 1 file with indirect coverage changes

martinfleis commented 10 months ago

Could use your input on testing the new explore

@knaaptime, do you mean guidance on how to test the result of explore?

knaaptime commented 10 months ago

Yeah. Looking at geopandas, like like you test for some known elements in the json output?

martinfleis commented 10 months ago

Yes. Folium can give you a string of the HTML it generates, and we just try to ensure that those bits we need are there in the number of occurrences we expect them.

knaaptime commented 10 months ago

thinking about this just a little bit more, i wonder if we should set the default neighbor color to yellow or something instead of blue. If you're stuck in LISA mode, you might assume blue is some sort of coldspot

martinfleis commented 10 months ago

That sounds very reasonable.