Closed martinfleis closed 4 months ago
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
2c0e0b2
) 69.4% compared to head (339435e
) 69.4%.
@martinfleis Is this ready for review?
@jGaboardi yup! Wasn't sure who's responsible here :).
Seems like you, @knaaptime, and @sjsrey have made the most recent commits. I'll add them for review as well.
Resolves the issue seen in https://github.com/pysal/libpysal/issues/681 where opencv causes installation headache. Since we already depend on shapely, there's no need to depend on OpenCV, so using shapely's minimum_rotated_rectangle, computing the angle manually and coercing the resulting array into the opencv-like order (which is the opposite compared to shapely).