search

pysal / pointpats

Planar Point Pattern Analysis in PySAL
https://pysal.org/pointpats/
BSD 3-Clause "New" or "Revised" License
80 stars 26 forks source link

keep members of local knox hotspots #134

Closed knaaptime closed 4 months ago

knaaptime commented 4 months ago

(also keep geometries)

knaaptime commented 4 months ago

definitely, just wanted a look first

knaaptime commented 4 months ago

I think we should make the conscious decision not to build on W moving forward, so this uses a Graph to generate the hotspot labels, which will implicitly force libpysal>=4 moving forward (hence the 3.8 test failure)

martinfleis commented 4 months ago

which will implicitly force libpysal>=4 moving forward

4.8, no?

knaaptime commented 4 months ago

sorry, yeah 48. I dont think thats a big deal, just wanted to flag in case someone disagrees?

jGaboardi commented 4 months ago

sorry, yeah 48. I dont think thats a big deal, just wanted to flag in case someone disagrees?

I'm all in.

martinfleis commented 4 months ago

The minimal CI env was not updated to libpysal 4.8 and is now failing on main (and also failed here).

knaaptime commented 4 months ago

yeah i want to do the CI in a separate commit, but needed this merged for a project we're working on. Will get the tests done shortly but i think its gonna be a messier diff